search

bazel-contrib / rules_fuzzing

Bazel Starlark extensions for defining fuzz tests in Bazel projects
Apache License 2.0
84 stars 20 forks source link

Add coverage support to C++ regression tests #212

Closed fmeum closed 1 year ago

fmeum commented 1 year ago

Co-authored-by: Zhen Yu Ding zhendeveloper@gmail.com

Closes #174

fmeum commented 1 year ago

@stefanbucur Could you review this? This differs from #174 in that the LCOV merger is no longer built without bazel coverage.

@zhenyudg I added you as a coauthor.

fmeum commented 1 year ago

@stefanbucur Friendly ping

stefanbucur commented 1 year ago

Thanks so much for the ping, it totally fell through the cracks. I'll take a look by EOD.

(PS: In general, please feel free to ping me if you don't get a review within a few days. Nowadays I'm spending less time on Github so things may easily slip off my attention.)

fmeum commented 1 year ago

LGTM, but we seem to have new test failures?

Looks like ~Bazel CI~ OSS-Fuzz replaced python with python3, which is incompatible with Bazel 4. I will try raising the minimum version and see whether that fixes the failure.

fmeum commented 1 year ago

@stefanbucur I updated the Bazel version to 5.0.0, which makes Bazel look for python3 in PATH. The CI run still fails, but when I run /usr/bin/env python3 in base-builder locally, that passes. Not sure what's wrong here.

stefanbucur commented 1 year ago

@stefanbucur I updated the Bazel version to 5.0.0, which makes Bazel look for python3 in PATH. The CI run still fails, but when I run /usr/bin/env python3 in base-builder locally, that passes. Not sure what's wrong here.

Interesting indeed 🤔 FWIW, the CI fuzzing test has been broken for about 3 weeks at head too: https://github.com/bazelbuild/rules_fuzzing/actions/workflows/oss_fuzz.yml

fmeum commented 1 year ago

@stefanbucur Tests are passing now.