search

bazel-contrib / rules_fuzzing

Bazel Starlark extensions for defining fuzz tests in Bazel projects
Apache License 2.0
87 stars 20 forks source link

Fix import to include full path #238

Closed acozzette closed 1 year ago

acozzette commented 1 year ago

This seems to be necessary for the project to build successfully with Bazel 6.

I also fixed some build errors related to Python 3.12, by upgrading to the most recent versions of absl, six, and rules_python.

stefanbucur commented 1 year ago

Happy to accept this, but I see some regression failures. Do you have a sense what might be going on there?

fmeum commented 1 year ago

This could very well be a regression caused by updates to the macOS runner. Probably worth trying to update rules_python to the latest version.

acozzette commented 1 year ago

I just pushed a few more fixes that should hopefully address the failure. I think @fmeum is right and this was caused by the MacOS runners recently upgrading to Python 3.12. We hit the same problem in protobuf recently.

I am going to be out for the next four weeks starting on Monday, so if this ends up not being mergeable as is then someone else may want to take over.