search

bazel-contrib / rules_go

Go rules for Bazel
Apache License 2.0
1.38k stars 659 forks source link

gomock.bzl: Use github.com/uber-go/mock instead of unmaintained github.com/golang/mock #3709

Open manjari25 opened 1 year ago

manjari25 commented 1 year ago

Starting June 2023, github.com/golang/mock is no longer maintained and has been archived. The repo forked from this at github.com/uber-go/mock is actively maintained and provides the same functionality.

rules_go should support a gomock.bzl rule that uses the maintained fork instead of the archived repo.

achew22 commented 1 year ago

The correct move here for us to do would be to remove go mock entirely then. Let's take this opportunity to mark the rule deprecated.

timofurrer commented 8 months ago

@achew22 can you elaborate on that decision? Why would you remove it entirely instead of just switching over to uber-go/mock ?

And is there any plans to continue with #3710 in case you decide to actually not deprecate it?