search

bazel-contrib / rules_go

Go rules for Bazel
Apache License 2.0
1.38k stars 656 forks source link

Is `nogo` still experimental? #3996

Closed albertocavalcante closed 1 month ago

albertocavalcante commented 2 months ago

I intend to use nogo for a production project, but the documentation still states:

WARNING: This functionality is experimental, so its API might change. Please do not rely on it for production use, but feel free to use it and file issues.

The first commit seems to be from 6 years ago - https://github.com/bazelbuild/rules_go/commit/a3c4fd9a29d7459015509965816934ffa46e6e60. Since rules_go itself has no v1.0, I don't know how to infer when the API has stabilized. Could you please confirm if this warning is still current?

Thanks!

fmeum commented 2 months ago

We haven't made any breaking changes to the nogo API in at least three years. I would consider it pretty stable, especially with the Bzlmod way of configuring it. I am actively working on making it more cache-friendly, but that change will be backwards compatible.

albertocavalcante commented 2 months ago

Thanks, @fmeum! I appreciate your quick response; that's what I wanted to confirm. Just before I close this, would it be OK to raise a PR to change the wording a little bit so someone would feel more comfortable adopting it? (If not, that's also fine.)

fmeum commented 2 months ago

Yes, such a change would be very welcome!