search

bazel-contrib / rules_go

Go rules for Bazel
Apache License 2.0
1.38k stars 656 forks source link

Lazy expand absolute path to avoid including them in the output #4009

Closed AlessandroPatti closed 2 months ago

AlessandroPatti commented 2 months ago

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

It fixes reproducibility issues reported in https://github.com/bazelbuild/rules_go/issues/3994 by lazy-expanding paths to absolute paths

Which issues(s) does this PR fix?

Fixes #3994

fmeum commented 2 months ago

@AlessandroPatti Tests are failing on macOS, presumably because the wrapper isn't fully transparent.

fmeum commented 2 months ago

Thanks, this is a really clean and well-tested solution!