Closed dzbarsky closed 1 month ago
What type of PR is this? starlark cleanup
What does this PR do? Why is it needed? Looks like we were adding the gotags from ctx.var multiple times when cgo was enabled. This led me to realize we can compute all tags at GoConfigInfo creation time.
gotags
GoConfigInfo
Which issues(s) does this PR fix?
Fixes #
Other notes for review
What type of PR is this? starlark cleanup
What does this PR do? Why is it needed? Looks like we were adding the
gotags
from ctx.var multiple times when cgo was enabled. This led me to realize we can compute all tags atGoConfigInfo
creation time.Which issues(s) does this PR fix?
Fixes #
Other notes for review