bazel-contrib / rules_go

Go rules for Bazel
Apache License 2.0
1.38k stars 656 forks source link

gomock: allow passing write_* flags to mockgen_tool #4067

Closed TvdW closed 1 month ago

TvdW commented 1 month ago

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Adds the ability to pass extra arguments to gomock

Which issues(s) does this PR fix?

Fixes #4065 Closes #4066

Other notes for review

I prefer #4066 but I'm filing this alternative PR in case the maintainers prefer to have each flag listed explicitly instead of passing arbitrary flags to mockgen_tool, especially considering some of these only work for a specific fork of mockgen (Uber's fork)

fmeum commented 1 month ago

4066 is cleaner