bazel-contrib / rules_go

Go rules for Bazel
Apache License 2.0
1.38k stars 656 forks source link

WIP: Try to avoid recompiling deps #4094

Closed dzbarsky closed 1 month ago

dzbarsky commented 1 month ago

I tried to follow what https://github.com/bazelbuild/rules_go/issues/4013#issuecomment-2286007545 observed, but I think this that log was misleading. I suspect the reason one of the packages was unused is that the test is too simple - if we had a another binary that depended on lib/dep and didn't participate in the cycle, it would have ended up using the other version of lib/dep.

So we probably do need an aspect if we want to clean this up

What type of PR is this?

Uncomment one line below and remove others.

Bug fix Feature Documentation Other

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Fixes #

Other notes for review