search

bazel-contrib / rules_go

Go rules for Bazel
Apache License 2.0
1.38k stars 656 forks source link

try and add an xdef to mimic what go toolset does for testing.Testing… #4096

Open paulgmiller opened 1 month ago

paulgmiller commented 1 month ago

See https://pkg.go.dev/testing\#Testing Go test sets an -X so that code knows if its in a UT

What type of PR is this? Feature?

What does this PR do? Why is it needed? Adds an xdef to mimic go test more precisely.

Should we only do for go > 1.23?

Which issues(s) does this PR fix?

Fixes #3686

Other notes for review

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.