search

bazel-contrib / rules_jsonnet

Jsonnet rules for Bazel
https://bazelbuild.github.io/rules_jsonnet/
Apache License 2.0
68 stars 73 forks source link

Upgrade go-jsonnet to to v0.18.0 #153

Closed groodt closed 2 years ago

groodt commented 2 years ago

Any thoughts on this CI failure @Globegitter @sparkprime ?

golang toolchain issue or new bazel 5.0 version?

UebelAndre commented 2 years ago

https://github.com/bazelbuild/rules_jsonnet/pull/152#issuecomment-1014023152 was what I thought the issue was.

groodt commented 2 years ago

#152 (comment) was what I thought the issue was.

Ah! Thanks! I didn't see somebody else tried to bump this.

UebelAndre commented 2 years ago

Ah! Thanks! I didn't see somebody else tried to bump this.

hehe all good! I only closed the PR to reduce the number of things I'm waiting on and didn't know if there were any maintainers around. But I do think the issue is in the upstream repositories trying to setup a host installed SDK. If I had bandwidth I'd try to change that and get a patch release out.

UebelAndre commented 2 years ago

@groodt would you be able to update @google_jsonnet_go//bazel:deps.bzl to either not use host or allow for pass-through arguments from the parent macro?

groodt commented 2 years ago

@UebelAndre Yes, I think I should be able to get to that over the next few days. I was planning on pass-through of a version string from jsonnet_go_dependencies.

groodt commented 2 years ago

This is now 💚 in CI @UebelAndre @sparkprime @Globegitter

I'll update the references to go-jsonnet once this is merged https://github.com/google/go-jsonnet/pull/595

groodt commented 2 years ago

Any chance you can take a look @Globegitter @sparkprime ?