search

bazel-contrib / rules_jvm

Contributed Bazel rules that make working with java projects more pleasant
Apache License 2.0
46 stars 59 forks source link

refactor: remove runner attribute from create_jvm_test_suite #289

Closed francine-blanc closed 2 months ago

francine-blanc commented 2 months ago

In create_jvm_test_suite.bzl, the runner attribute is not utilised within the define_test function. By the time we reach the create_jvm_test_suite macro, this attribute is redundant because the specific test runner can be directly specified within the define_test function provided by the user. So, this PR removes references to the runner from the macro.

sitaktif commented 2 months ago

A consequence of this changes is that for existing users, the runner attribute is now going to be passed to the define_test function (via kwargs). Just checking that this change is intended and that it's acceptable in terms of backward incompatibility.

shs96c commented 2 months ago

That’s fine. This macro is seldom used, as it’s a building block for the higher level suite macros.

francine-blanc commented 2 months ago

@shs96c would you be able to trigger the pipeline again please?