search

bazel-contrib / rules_jvm_external

Bazel rules to resolve, fetch and export Maven artifacts
Apache License 2.0
337 stars 256 forks source link

bug: java_export doesn't set default javadocopts #1245

Closed comius closed 1 day ago

comius commented 2 months ago

Version: 6.3

Reproduction:

Workaround: set javadocopts to expected defaults (or just to ["-Xdoclint:-missing"])

jin commented 1 day ago

At HEAD now, looks like the defaults are being set correctly: 

jingwen@jingwen-mac java-export % bazel build //src/main/java/com/github/bazelbuild/rulesjvmexternal/example/io:io-docs -s
INFO: Analyzed target //src/main/java/com/github/bazelbuild/rulesjvmexternal/example/io:io-docs (1 packages loaded, 4 targets configured).
SUBCOMMAND: # //src/main/java/com/github/bazelbuild/rulesjvmexternal/example/io:io-docs [action 'Action src/main/java/com/github/bazelbuild/rulesjvmexternal/example/io/io-docs.jar', configuration: 6d047db91b013d29fd498ba2440e2ddc800ee62b44dc617939d11125fbd222c9, execution platform: @@local_config_platform//:host, mnemonic: Action]
(cd /private/var/tmp/_bazel_jingwen/d7cf70b00869fc76f85d1a9ad93c70ce/execroot/_main && \
  exec env - \
  bazel-out/darwin_arm64-opt-exec-ST-13d3ddad9198/bin/external/rules_jvm_external~/private/tools/java/com/github/bazelbuild/rules_jvm_external/javadoc/javadoc --out bazel-out/darwin_arm64-fastbuild/bin/src/main/java/com/github/bazelbuild/rulesjvmexternal/example/io/io-docs.jar ... -notimestamp -use -quiet -Xdoclint:-missing -encoding UTF8)

Let me know if this still repros for you.