bazel-contrib / rules_jvm_external

Bazel rules to resolve, fetch and export Maven artifacts
Apache License 2.0
337 stars 256 forks source link

[Bazel CI] Build failure due to missing android_binary definition in override_targets BUILD file #1258

Closed sgowroji closed 1 week ago

sgowroji commented 2 months ago

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4156#019236d0-9877-49a9-bded-dc70b68e5231

Platform: Ubuntu

Logs:

ERROR: /var/lib/buildkite-agent/builds/bk-docker-9dtz/bazel-org-repo-root/rules_jvm_external/tests/integration/override_targets/BUILD:10:1: name 'android_binary' is not defined
ERROR: Skipping '//tests/integration/override_targets:override_targets': no such target '//tests/integration/override_targets:override_targets': target 'override_targets' not declared in package 'tests/integration/override_targets' defined by /var/lib/buildkite-agent/builds/bk-docker-9dtz/bazel-org-repo-root/rules_jvm_external/tests/integration/override_targets/BUILD
ERROR: no such target '//tests/integration/override_targets:override_targets': target 'override_targets' not declared in package 'tests/integration/override_targets' defined by /var/lib/buildkite-agent/builds/bk-docker-9dtz/bazel-org-repo-root/rules_jvm_external/tests/integration/override_targets/BUILD

Culprit:

Steps:

 git clone https://github.com/bazelbuild/rules_jvm_external
git reset 2deeda518cf1ccb847c6e188bb3bf7d3f6fb7496  --hard
export USE_BAZEL_VERSION=dfba96d081091e1e17c4f2b9970e8f79fca1dce6
bazel test //tests/integration/override_targets:override_targets 

CC Greenteam @mai93

ahumesky commented 1 month ago

This is from the overall effort to remove the android rules from bazel, the work to update rules_jvm_external to Starlark rules_android is here: https://github.com/bazel-contrib/rules_jvm_external/pull/1215

jin commented 1 week ago

Closing as duplicate of https://github.com/bazel-contrib/rules_jvm_external/pull/1215