search

bazel-contrib / rules_jvm_external

Bazel rules to resolve, fetch and export Maven artifacts
Apache License 2.0
337 stars 256 forks source link

Remove android_extensions.bzl load #1268

Open keith opened 1 month ago

keith commented 1 month ago

This has been removed from bazel 8.x, and is included in rules_android now

shs96c commented 1 month ago

Those failures look legitimate.

We support "N-2" bazel LTS releases, which once Bazel 8 ships will mean that we want to continue supporting Bazel 6 workspace-based builds. I'm assuming that this change will continue to work with Bazel 6 once we land this?

ahumesky commented 1 month ago

The failures in CI are because the Starlark rules in rules_android 0.5.1 rely on the natively-defined Android providers, which are available only with --experimental_google_legacy_api. The upcoming version 0.6.0 of rules_android uses Starlark-defined providers, except for ProguardSpecInfo (because it's in the java rules) which is unguarded from --experimental_google_legacy_api in Bazel 7.4.0 and Bazel 8

I suggest trying this PR with rules_android 0.6.0 when it becomes available.

There's some related discussion around compatibility in https://github.com/bazel-contrib/rules_jvm_external/issues/1270#issuecomment-2438271500