Ensure no duplicates after pom jar unification

bazel-contrib / rules_jvm_external

Bazel rules to resolve, fetch and export Maven artifacts

Apache License 2.0

337 stars 256 forks source link

Ensure no duplicates after pom jar unification #1269

Closed cerisier closed 1 week ago

cerisier commented 1 month ago

The same artifact can being depended on via pom and jar at different places in the tree. In such case, we deduplicate it so that 2 entries do not reference the same file, which will otherwise lead in symlink error because of existing file down the road.

Fixes #1267

honnix commented 1 month ago

FWIW, #1266 also addresses the same issue.

jin commented 1 week ago

Thanks for this PR! I've merged https://github.com/bazel-contrib/rules_jvm_external/pull/1266 as that PR came first.