Closed plule-ansys closed 3 years ago
This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!
Hello, attached is a reproduction with the latest version of rules_nodejs
This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!
This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"
🐞 bug report
Affected Rule
The issue is visible in the rule `karma_web_test_suite()` ### Is this a regression? Not that I know ### Description With `package.json`, `yarn.lock` and `node_modules` located in a subfolder, the `karma_web_test_suite()` will fail if there is another `node_modules` folder located at the root folder. When launching the test, this other `node_modules` folder will be picked up. If it doesn’t exist, this scenario works fine. ## 🔬 Minimal Reproduction Extract attachment [rules_nodejs_node_modules_subfolder.zip](https://github.com/bazelbuild/rules_nodejs/files/5134919/rules_nodejs_node_modules_subfolder.zip). This is the `example_webtesting` example moved to a subfolder, and an additional dummy `node_modules` folder at the root. `bazel test //...` fails. Remove the `node_modules` folder located at the root of the workspace. `bazel test //...` succeed. ## 🔥 Exception or Error The test log fails with: (Probably irrelevant) In both succeeded and failing scenarios, the debug build log contains a lot of: ``` DEBUG: C:/users/plule/_bazel_plule/czpp2oy5/external/build_bazel_rules_nodejs/internal/linker/link_node_modules.bzl:19:14: [link_node_modules.bzl] No LinkablePackageInfo for @npm//ent:ent__nested_node_modules ``` ## 🌍 Your Environment **Operating System:** **Output of `bazel version`:** **Rules_nodejs version:** **Anything else relevant?** Loosely related #1373 but there is nothing about a folder being picked in priority or not, or being specific to Windows On Linux, I don't have any difference with or without this folder.