search

bazel-contrib / rules_nodejs

NodeJS toolchain for Bazel.
https://bazelbuild.github.io/rules_nodejs/
Apache License 2.0
732 stars 523 forks source link

npm_version_check could help more with minor/patch version skew #2155

Closed alexeagle closed 4 years ago

alexeagle commented 4 years ago

Recently a few users have tripped over the assumption that updating rules_nodejs version in their WORKSPACE would get new features, but missed our statement in each release notes "and update @bazel-scoped packages"

We could change the version check (eg https://unpkg.com/browse/@bazel/typescript@2.0.3/npm_version_check.js) to be more helpful. This comment https://github.com/bazelbuild/rules_nodejs/pull/1519#issuecomment-570700367 suggested that we could have another attribute somewhere to opt-in or opt-out of that checking.

Another improvement could be to give an upgrade command that covers everything (maybe it lists all our monorepo-published packages which are versioned together)

github-actions[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

github-actions[bot] commented 4 years ago

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"