search

bazel-contrib / rules_oci

Bazel rules for building OCI containers
Apache License 2.0
280 stars 146 forks source link

Allow layers to take in files other than .tar and .tar.gz #519

Closed jeremy-devuyst closed 6 months ago

jeremy-devuyst commented 6 months ago

We've been using bazel-lib tar to make layers for oci_images. It supports adding compress = "zstd". It has actually been working fine and speeding up our builds quite a bit. However, as I've updated bazel-lib, the generated tar file now has a .tar.zst extension instead of a .tar extension. Only now do oci_images complain since they only accept .tar and .tar.gz files. I'm wondering if it should not already be allowed to take more than just those file extensions since it has been able to handle zstd compressed tars already.

alexeagle commented 6 months ago

Want to patch in https://github.com/bazel-contrib/rules_oci/pull/523 and check that fixes it?

jeremy-devuyst commented 6 months ago

Works perfectly well, thank you!