search

bazel-contrib / rules_oci

Bazel rules for building OCI containers
Apache License 2.0
298 stars 157 forks source link

Bug: aspect_bazel_lib dependency is leaking into users module #575

Open thesayyn opened 5 months ago

thesayyn commented 5 months ago

It looks like load statement in the BUILD file generated by oci_pull, leaks the aspect_bazel_lib dependency onto users. Investigate why.

abrisco commented 2 months ago

Could this not be fixed by vendoring any aspect_bazel_lib code being used into rules_oci?

abrisco commented 2 months ago

I think this is the source of the leak: https://github.com/bazel-contrib/rules_oci/blob/ffaa615c346a31f45730860a8635a29ca2c7d52a/oci/private/pull.bzl#L163-L181

Could that rule be vendored into rules_oci or a minimal version written to be used instead?