search

bazel-contrib / rules_perl

Perl rules for Bazel
Apache License 2.0
26 stars 37 forks source link

Allow Perl source with no file extension #39

Closed fmeum closed 2 years ago

fmeum commented 2 years ago

Perl source files without a file extension are relatively common (genhtml is an example).

PiotrSikora commented 2 years ago

Could you add an example and a test based on genhtml (or anything else that would exercise this path? See: https://github.com/bazelbuild/rules_perl/pull/23 for a similar change.

fmeum commented 2 years ago

@PiotrSikora I added a simple test that runs genhtml to generate a coverage report for the test itself. I barely know any Perl, so feedback is especially welcome.

fmeum commented 2 years ago

The CI failures are unrelated and fixed by https://github.com/bazelbuild/rules_perl/pull/41.

skeletonkey commented 2 years ago

MR 41 has been merged in - please rebase

skeletonkey commented 2 years ago

Looks good - but I believe you still need to rebase.

fmeum commented 2 years ago

It was a different buildifier issue that I introduced with this PR (and just fixed). Should be ready now.