search

bazel-contrib / rules_perl

Perl rules for Bazel
Apache License 2.0
26 stars 37 forks source link

Replace find_cpp_toolchain with find_cc_toolchain #49

Closed comius closed 2 years ago

comius commented 2 years ago

This properly resolve CPP toolchain when Cc toolchainisation is enabled.

comius commented 2 years ago

Hey @skeletonkey can I ask for a speedy review here? It's blocking Bazel LTS cut.

skeletonkey commented 2 years ago

@comius sorry for the delay. Please confirm that this MR needs to happen before bazelbuild/bazel/pull/16252. Are there any potential risks for committing this before that PR?

comius commented 2 years ago

@comius sorry for the delay. Please confirm that this MR needs to happen before bazelbuild/bazel/pull/16252. Are there any potential risks for committing this before that PR?

Correct.

I don't think there are any risk. find_cc_toolchain is implemented defensively and should work with older Bazel versions. It's obtained from a fixed version of rules_cc.

skeletonkey commented 2 years ago

Thank you - merging it now.