bazel-contrib / rules_perl

Perl rules for Bazel
Apache License 2.0
26 stars 37 forks source link

Don't test on Ubuntu 14.04 #5

Closed philwo closed 5 years ago

philwo commented 5 years ago

Ubuntu 14.04 is about to be end-of-life and Bazel CI will stop supporting it shortly afterwards.

Context: https://groups.google.com/d/msg/bazel-dev/_D6XzfNkQQE/8TNKiNmsCAAJ

philwo commented 5 years ago

Any idea why this fails on Ubuntu 18.04?

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //examples/fibonacci:fibonacci_test
-----------------------------------------------------------------------------
/home/bazel/.cache/bazel/_bazel_bazel/ec321eb2cc2d0f8f91b676b6d4c66c29/execroot/io_bazel_rules_perl/bazel-out/k8-fastbuild/bin/examples/fibonacci/fibonacci_test.runfiles
1..13
Can't locate examples/fibonacci/fibonacci.pm in @INC (you may need to install the examples::fibonacci::fibonacci module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.26.1 /usr/local/share/perl/5.26.1 /usr/lib/x86_64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /home/bazel/.cache/bazel/_bazel_bazel/ec321eb2cc2d0f8f91b676b6d4c66c29/execroot/io_bazel_rules_perl/bazel-out/k8-fastbuild/bin/examples/fibonacci/fibonacci_test.runfiles/io_bazel_rules_perl/examples/fibonacci/fibonacci_test.t line 20.
BEGIN failed--compilation aborted at /home/bazel/.cache/bazel/_bazel_bazel/ec321eb2cc2d0f8f91b676b6d4c66c29/execroot/io_bazel_rules_perl/bazel-out/k8-fastbuild/bin/examples/fibonacci/fibonacci_test.runfiles/io_bazel_rules_perl/examples/fibonacci/fibonacci_test.t line 20.
# Looks like your test exited with 2 before it could output anything.

https://buildkite.com/bazel/rules-perl/builds/68#52fdd0c4-5731-4ecb-a749-4b2bf8a07964

philwo commented 5 years ago

No response from project maintainers in weeks. I'm using my admin permissions to merge this.

PiotrSikora commented 5 years ago

Oops, my apologies, @philwo! I got so distracted with why this doesn't work on Ubuntu 18.04 (which I didn't figure out yet), that I didn't notice that this PR was about removing Ubuntu 14.04 and ready to go.

philwo commented 5 years ago

Oh, no worries 😊 Feel free to add the ubuntu1804 config when you figure out what's up!

pziggo commented 4 years ago

As mentioned here https://github.com/bazelbuild/rules_perl/pull/11#issuecomment-568552453 , the current directory (".") has been removed from @INC in version >= 5.26 due to security issues. Thus the current implementation of the rules is incompatible in general with Ubuntu 18.04 and other distress using a newer version of perl as far as I can tell.

See also: https://metacpan.org/pod/release/XSAWYERX/perl-5.26.0/pod/perldelta.pod#Removal-of-the-current-directory-(%22.%22)-from-@INC