search

bazel-contrib / setup-bazel

GitHub Action to configure Bazel
MIT License
16 stars 5 forks source link

Determine if rulesets should be using this for their testing #1

Closed alexeagle closed 4 months ago

alexeagle commented 4 months ago

As part of moving this repo to bazel-contrib, I'm curious if we should consider changing https://github.com/bazel-contrib/rules-template/blob/main/.github/workflows/ci.yaml to use this. I wrote that reusable action that it references but it's not sophisticated about the caching.

alexeagle commented 4 months ago

I'm starting on this here: https://github.com/bazel-contrib/.github/pull/13

p0deje commented 4 months ago

Yes, we can absolutely use the action, though I wonder if rulesets want caches enabled at all - it seems to me that a cacheless setup is preferred, at least that's what we do in rules_ruby.

alexeagle commented 4 months ago

What are the pros and cons of using this for rulesets? How do you feel they are different from other projects?

p0deje commented 4 months ago

The main reason I'm not using the caches in rulesets is that I want to make sure the toolchains can be installed from scratch. This way I could catch regressions in repository rules that for example download and compile Ruby.

alexeagle commented 4 months ago

It's useful just for the bazelrc to set enable_bzlmod, and I think the repository cache as well since it contains content-addressed bytes and only accessed when the user supplies an integrity hash. So, I think the answer is yes :)