Have -enforce-clean cause a failure when "before" location is unlcean

bazel-contrib / target-determinator

Determines which Bazel targets were affected between two git commits.

Apache License 2.0

144 stars 22 forks source link

Have -enforce-clean cause a failure when "before" location is unlcean #86

Closed michaelboyd2 closed 6 months ago

michaelboyd2 commented 6 months ago

We encountered a problem where a feature branch had a .gitignored file, but this was not in the main branch .gitignore. Even when using -enforce-clean, this caused target determinator to identify all targets as changed in the workspace.

This change is to make this situation cause a failure instead.

Closes #85

illicitonion commented 6 months ago

This looks good to me - I made a PR to this PR with a few suggestions: https://github.com/michaelboyd2/target-determinator/pull/1 - please take a look and merge it if you're happy, and I'll merge this one :) Thanks for taking the time!

michaelboyd2 commented 6 months ago

Thanks very much, merged your suggestions.