search

bazel-contrib / toolchains_llvm

LLVM toolchain for bazel
Apache License 2.0
283 stars 206 forks source link

Fix support for --incompatible_disallow_empty_glob #331

Closed keith closed 1 month ago

keith commented 2 months ago

This allows downstream repos to set this flag

rrbutani commented 2 months ago

@keith would you mind adding allow_empty here?

https://github.com/bazel-contrib/toolchains_llvm/blob/be777a3a39dfe5f16ce6beda2062d50d71c74ebf/tests/openssl/openssl.bazel#L840-L845

Or we can just remove 'crypto/include/*.h'.

keith commented 2 months ago

added! we'll see!

rockwood-openai commented 1 month ago

Ping on this, would be great to land it :)