search

bazel-ios / cocoapods-bazel

A Cocoapods plugin for automatically generating Bazel BUILD files
Apache License 2.0
110 stars 21 forks source link

Adding supported architectures filter for armv7s and arm64e #46

Closed ethan-gates closed 3 years ago

ethan-gates commented 3 years ago

I was receiving an error for vendored xcframeworks that list arm64e and armv7s as supported architectures, but filtering them out fixed the issue.

The error was showing no such target '@build_bazel_rules_apple//apple:ios_armv7s': target 'ios_armv7s' not declared in package 'apple' (did you mean 'ios_armv7'?)

congt commented 3 years ago

Hi @ethan-gates, thanks for the PR! I wonder if we can filter these architectures in rules_ios? We've already filtered some xcframework slices there. It will also be easy to support them in future without regenerating the build files.

ethan-gates commented 3 years ago

Hi @congt, I'll test that out but that seems good to me. Thanks for the quick response!

ethan-gates commented 3 years ago

Filtering on rules_ios worked great! Please see the associated PR: https://github.com/bazel-ios/rules_ios/pull/309