bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
278 stars 85 forks source link

Fix not allowing custom bundle_name #770

Closed luispadron closed 1 year ago

luispadron commented 1 year ago

Broken in https://github.com/bazel-ios/rules_ios/pull/754, this fixes by taking the given bundle_name or the name if not provided

luispadron commented 1 year ago

What command needs to be run to re-generate the Xcode projects? It seems like whatever I do it breaks the diff test because of arm64 paths:

arch -arch x86_64 /bin/bash -l -c "./tests/xcodeproj-tests.sh --update"

From:

https://github.com/bazel-ios/rules_ios/blob/master/tests/xcodeproj-tests.sh#L86-L92

thiagohmcruz commented 1 year ago

What command needs to be run to re-generate the Xcode projects? It seems like whatever I do it breaks the diff test because of arm64 paths:

arch -arch x86_64 /bin/bash -l -c "./tests/xcodeproj-tests.sh --update"

From:

https://github.com/bazel-ios/rules_ios/blob/master/tests/xcodeproj-tests.sh#L86-L92

This works:

arch -arch x86_64 /bin/bash -l -c "./tests/xcodeproj-tests.sh --update"

but it has some caveats:

because my bazelisk is placed here (from which bazelisk)

/usr/local/bin/bazelisk



I just ran that command from `master` and it noop-ed for me as expected.