bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

Update precompiled_apple_resource_bundle to not include executable_name #801

Closed luispadron closed 10 months ago

luispadron commented 10 months ago

Fixes #800

Recent changes have made it so that bundle_name OR executable_name are used for the CFExecutable plist substitution: https://github.com/bazelbuild/rules_apple/commit/f909b0b6f31dee7ee9ba9998a92404eaeb7af727#diff-fd21ff183af5a0af8861d50117a7a377b04a0b7d9924600f424261b7db57e2deL279

This causes App store rejection, we should set include_executable_name to False to ensure its not substituted/included in the plist.