search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

Add option to disable modulemap generation #802

Closed luispadron closed 10 months ago

luispadron commented 10 months ago

When maintaining two build systems (Xcode and Bazel) it's useful to be able to configure what is and isn't generated. In our case, we only generate modulemaps for frameworks which enable this feature in our Xcode setup. In bazel however, this file is generated regardless.

This leads to build inconsistency where Xcode fails to build because a missing modulemap is not found while Bazel continues to pass since these are always generated.

Instead, we should allow users to enable/disable this behavior. With this change generate_default_modulemap will be defaulted to True (so no changes here) unless you set to False in which case no modulemap is generated.

luispadron commented 10 months ago

Converting to a draft, not sure this solves our specific issue just yet.

luispadron commented 10 months ago

We chose to instead catch this issue in our existing setup vs. in here. Closing this.