search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

Support Swift Macro #805

Closed qyang-nj closed 10 months ago

qyang-nj commented 10 months ago

Make apple_framework support swift compiler plugins.

qyang-nj commented 10 months ago

Mind adding a test fixture that exercises this attr 🙏🏼

I'm not sure how to add a test just for "rules_apple 3.x" 🤔

luispadron commented 10 months ago

Mind adding a test fixture that exercises this attr 🙏🏼

I'm not sure how to add a test just for "rules_apple 3.x" 🤔

@jerrymarino do you have suggestions

jerrymarino commented 10 months ago

Is it possible you'd use a select statement for the plugins attribute you're setting; where the select contains a default condition for your plugins but nothing for the LTS stuff?

qyang-nj commented 10 months ago

I'm seeing this error. Somehow I cannot use Xcode 15 for this repo. 🤔

Error in fail: Swift compiler plugins require Swift 5.9+
luispadron commented 10 months ago

Ah we need to update CI to support that version. I think this PR is good as-is and we can follow up with a test when we can support it.

qyang-nj commented 10 months ago

Sounds good. Thank you. I'm happy to add the tests after the CI supports it.