search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

Ignore MODULE.bazel.lock #806

Closed mattrobmattrob closed 10 months ago

mattrobmattrob commented 10 months ago

This file is generated by default by bazel @ HEAD but we don't really want to manage it. This way it can be generated locally and folks can build offline if they have generated it at least once.

luispadron commented 10 months ago

seems fine for now but this looks to go against what's suggested here: https://bazel.build/external/lockfile

Include the lockfile in version control to facilitate collaboration and ensure that all team members have access to the same lockfile, promoting consistent development environments across the project.

mattrobmattrob commented 10 months ago

seems fine for now but this looks to go against what's suggested here: https://bazel.build/external/lockfile

Include the lockfile in version control to facilitate collaboration and ensure that all team members have access to the same lockfile, promoting consistent development environments across the project.

I'm following https://github.com/bazelbuild/rules_swift/commit/d0687c3c9957633376a7099d03e0ced183f64f75 for now. IMO, it's probably a different rationale for rulesets vs. normal repos but 🤷

luispadron commented 10 months ago

Ah that's fair