Add `toolchains` to rules that use `@bazel_tools//tools/cpp:toolchain_type`

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks

Apache License 2.0

276 stars 85 forks source link

Add `toolchains` to rules that use `@bazel_tools//tools/cpp:toolchain_type` #807

Closed mattrobmattrob closed 9 months ago

mattrobmattrob commented 10 months ago

Fix the following from https://github.com/bazel-ios/rules_ios/issues/795:

Error in fail: In order to use find_cpp_toolchain, you must include the '@bazel_tools//tools/cpp:toolchain_type' in the toolchains argument to your rule.

mattrobmattrob commented 9 months ago

Given the discussion in https://bazelbuild.slack.com/archives/CD3QY5C2X/p1701890904270059, I'm less worried about the sysroot issue. Let's merge this and we can revert if there are problems.