search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

Allow select in test_host parameter #820

Closed codeman9 closed 8 months ago

codeman9 commented 8 months ago

Previously, using a select in the test_host parameter would result in the error:

ERROR: rules_ios/tests/ios/unit-test/BUILD.bazel:51:14: //tests/ios/unit-test:ExplicitHostedWithSelect.dep_middleman: expected value of type 'string' for element 0 of attribute 'test_deps' in 'dep_middleman' rule, but got select({"//tests/ios/unit-test:use_other_test_host": "//rules/test_host_app:iOS-9.3-AppHost", "//conditions:default": "//rules/test_host_app:iOS-14.0-AppHost"}) (select)

I simply removed the test_deps parameter as that wasn't really being used for anything of value that I could see. It was only ever being set to the test_host parameter or an empty list of which neither contain the AvoidDepsInfo information that was being deduplicated.

ob commented 8 months ago

@ethan-gates or @ob, do you all use test_deps in your setup?

Not that I'm aware of, good riddance I say.

mattrobmattrob commented 8 months ago

I'm going to merge this since we have the confirmed lack of usage from the large stakeholders. Please comment here or open an issue if this change causes issues for any future readers.