bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 84 forks source link

Fix duplicate symbols for test rules #844

Closed luispadron closed 5 months ago

luispadron commented 5 months ago

This makes changes to test.bzl to remove the default internal_test_deps being added to all snapshot tests. This is causing duplicate symbol issues in Bazel 7 as framework search path logic has changed. In Bazel 7, the snapshot test target can't depend on the runfiles lib without introducing duplicate symbols at link time, this is because the BazelRunfiles target it depends on already links the runefiles lib. This updates the rule / usage of it to pass this dependency explicitly so it can be removed in the bazel 7 branch but maintained here for others who need it.

Changes:

luispadron commented 5 months ago

Made some changes to prepare the target for Bazel 7 along with adding a is_bazel_7 constant similarly to how they determine this in rules_apple