Closed tymurmustafaiev closed 4 months ago
Thanks, this is a nice cleanup! If this requires a new rules_apple version you'll have to rebase after I merge #864
Thanks, this is a nice cleanup! If this requires a new rules_apple version you'll have to rebase after I merge #864
Cool, thx!
Why this is needed?
fake_rule_label
was as a workaround and I'd like to remove it and use swift_module. This pr is a continuation of https://github.com/bazelbuild/rules_apple/pull/2335. If we try to build 2 different targets with same module name - plist generation will fail due to rule name collision asfake_rule_label
is used, which was created fromswift_module
orbundle_name
What has changed? Using
swift_module
for compiling assets, plists, storyboards, etc. instead offake_rule_label
. Now, each plist generation action has it's own rule name which has no name collisionNOTE This PR Requires
rules_apple
to be at least 3.2.0, so I'll fix tests once it's updated