bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 84 forks source link

Update to rules_apple 3.5.1 minimum supported version #866

Closed luispadron closed 4 months ago

luispadron commented 4 months ago

3.5.1 includes a fix we need to get in for codesigntool to work correctly. This increases min version of rules_apple to 3.5.1 for version 4.3.1 of rules_ios (to be released)

brentleyjones commented 4 months ago

4.4.0 of rules_ios (to be released)

Why not a patch release?

luispadron commented 4 months ago

4.4.0 of rules_ios (to be released)

Why not a patch release?

honestly not sure what would be more typical here, its not a bug fix in this repo but does increase the version. Thoughts @mattrobmattrob?

mattrobmattrob commented 4 months ago

🤷 Patch is probably the correct version bump based on semver but I don't feel strongly.

luispadron commented 4 months ago

Updated