search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 84 forks source link

Bazel 7: Set framework_includes in import_middleman #877

Closed thiagohmcruz closed 2 months ago

thiagohmcruz commented 2 months ago

Continuation of: https://github.com/bazel-ios/rules_ios/pull/873

While testing Bazel 7 hit some build failures due to missing -F flags in the invocation.

I could set other attributes here too but since I'm not super familiar with this rule I'd rather add what is missing progressively as I run tests in Bazel 7.

mattrobmattrob commented 2 months ago

Is it easy to add a test that demonstrates this failure on th Bazel 7.X test jobs?

thiagohmcruz commented 2 months ago

Is it easy to add a test that demonstrates this failure on th Bazel 7.X test jobs?

@mattrobmattrob not sure but I'll take all look

thiagohmcruz commented 2 months ago

@mattrobmattrob just FYI I'll add a test to this in a follow up. Couldn't find an easy way to repro what I see inside yet.