bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 84 forks source link

Move resource generation below framework vfs #880

Closed luispadron closed 1 month ago

luispadron commented 1 month ago

This moves resource generation (and being added to deps) below the framework_vfs creation which uses the deps

With the change in #879 to add the vfs to the swiftc_inputs instead of the deps of the swift_library the framework_vfs was now also forwarding the resources (because it gets added to deps after generation) to other rules (like rules_xcodeproj) which collect extra files from this the swiftc_inputs attr. This led to duplicated resources in the project as they're collected from resources and now the transitive deps of the framework_vfs

AFAIK resources aren't needed for the framework_vfs rules and so this change should resolve the new rules_xcodeproj incompatibility while making the deps to the framework_vfs more scoped.