search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

Add sandbox mode to CI testing matrix #895

Closed gyfelton closed 4 weeks ago

gyfelton commented 4 weeks ago

What changed:

  1. Add sandbox on/off to testing matrix, so we have 2 bazel version VFS on/off sandbox on off = 8 tests in total ATM
  2. Fix redefinition of AppErrorCode enum error in sandbox mode by removing the extra import in bridging header. The tests still works and can catch renaming of the enum for example. Why it was working in non sandbox mode is unknown
  3. Add sandbox config to include all settings needed to pass CI. specifically allow a small set of actions to run locally.

Why this change: To add CI coverage to sandbox mode to ensure no regression on it, now that we have fixed issues with sandbox mode in https://github.com/bazel-ios/rules_ios/pull/894

Discussion: CI duration might be a concern, we can exclude certain combo in the test matrix if we want, it's possible with exclude keyword

luispadron commented 4 weeks ago

Updated the required check in GitHub this should be ready once CI completes