search

bazel-ios / rules_ios

Bazel rules for building iOS applications and frameworks
Apache License 2.0
276 stars 85 forks source link

fix bazel7 sim_arm64 dynamic framework link error, pass dynamic framework info #915

Open kuperxu opened 5 days ago

kuperxu commented 5 days ago

When the "apple.arm64_simulator_use_device_deps" feature is enabled, dynamic framework information is not passed to Bazel. As a result, the linker encounters errors when attempting to link dynamic frameworks.

kuperxu commented 5 days ago

hi @luispadron, Help review the code. plz

luispadron commented 5 days ago

I don't use this rule, but @thiagohmcruz @gyfelton can help here

kuperxu commented 3 days ago

@thiagohmcruz @gyfelton please help me with the review, I didn't add the reviewer permissions.

gyfelton commented 1 day ago

kicking CI to build. Am I right that the added @import statement was a red to green test case with your fix? 🙏

gyfelton commented 1 day ago

seems that CI are failing with 

# Execution platform: @local_config_platform//:host
tests/ios/in-tree-vendor-prebuilt-deps/dynamic/app/App/main.m:3:9: fatal error: module 'MobileFlow' not found
@import MobileFlow;
 ~~~~~~~^~~~~~~~~~