Closed jerrymarino closed 4 years ago
Would it be good to address the failures in your Tulsi PR before landing this?
Hey @garrettmoon - we should be good to land as tulsi takes these build files as an input, so as long as they match what it's expecting it will work ✅
In order to use
expand_location
we need to have a dep on the input. https://docs.bazel.build/versions/master/skylark/lib/ctx.html#expand_locationPrivate module maps used in swift library that were previously not
deps
, and they are specified now specified as header, so they remain private. If we fixswiftc_inputs
to be expandable in Bazel this would be unnecessary.For xcode project generation we need to call
expand_location
and the aspect will fail if it doesn't have it as a dep. The corresponding code is added to Tulsi and XCHammer https://github.com/bazelbuild/tulsi/pull/157