search

bazel-xcode / PodToBUILD

An easy way to integrate CocoaPods into Bazel
Apache License 2.0
322 stars 69 forks source link

Update Apple/Swift/Bazel versions to allow building with Xcode 10.2 #78

Closed FuegoFro closed 5 years ago

FuegoFro commented 5 years ago

The goal with this is to update the dependencies to include This updates the rules_apple dependency to latest in order to pull in https://github.com/bazelbuild/rules_swift/commit/19db162c614af9c9db354e14d68965c8eb58e348 and allow compiling with Xcode 10.2. This also switches to using the version of rules_swift included by rules_apple, rather than manually specifying it.

Finally, this upgrades the version of Bazel being used to be compatible with the newer versions of rules_apple and rules_swift.

This seems like it partially addresses https://github.com/pinterest/PodToBUILD/issues/74, but that also mentions other tasks like updating other projects and CI.

FuegoFro commented 5 years ago

Ah sorry, just realized there's already an open PR for this at https://github.com/pinterest/PodToBUILD/pull/75. If that's the preferred place for these changes, I can go ahead and close this in preference of that 🙂

jerrymarino commented 5 years ago

Hey @FuegoFro - thanks so much for the PR! Sorry for the latency on this update, I'm just now getting towards updating to 10.2. It looks like a few PRs are needed for this / @rahul-malik 's recent PRs around the new bundle rules.

I think we also want to update all the other places that we hardcode Bazel versions for integration tests like in #75 . I think it'd be best to update to the latest version of Bazel/RulesApple/etc if possible ( like in this one ).

Additionally, we should update the travis CI config to make master run on the newest version of Xcode and make sure it all passes.

I also need to do this update, so happy to help out merge PRs / do reviews today and tomorrow.

FuegoFro commented 5 years ago

Awesome, thank you for the reply!

I took a stab at updating the rest of the hard coded version to point at 0.25.2 and fixing the resulting issues. make ci now passes locally for me. I also changed the Travis definition to use the 10.2 image; we'll see if that works properly 🙂

At this point I think the only change from https://github.com/pinterest/PodToBUILD/pull/75 that isn't in here is the Sources/PodToBUILD/ObjcLibrary.swift one, which fixes a deprecation warning. I figure it would be okay to have that in a separate PR since it's not blocking/breaking this, but let me know if you think otherwise 🙂

FuegoFro commented 5 years ago

Hey there! Just wanted to check in and see if there's any possibility of getting this and some of the other PRs I've opened looked at. It looks like CI is fully passing with my latest changes here so I think this should be good to merge in, unless you have other changes you'd like to see. Thank you!

jerrymarino commented 5 years ago

Thanks so much for sending over this PR and the other ones 👍. Glad to see that the CI is passing now. I left a few comments on your other ones and I’m working my way through all the open PRs we’ve got here.

FuegoFro commented 5 years ago

Thank you so much! 😀