Normalize and absolutize paths before comparing them

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files

Apache License 2.0

39 stars 19 forks source link

Normalize and absolutize paths before comparing them #10

Closed cgrushko closed 6 years ago

cgrushko commented 6 years ago

This fixes a case where calling JavasourceFileParser with the result of find . would result in ignoring --one_rule_per_package_roots, because one kind of path would include ./ and the other would not.

cgrushko commented 6 years ago

@petroseskinder I can't put you as a reviewer, so please review manually if you have the time.

petroseskinder commented 6 years ago

Can you "at" me for future reviews? Also, @damienmg @davidstanke is there anything I can do so I can be added as a reviewer?