search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

BFG should set a default visibility in all generated BUILD files #11

Open cgrushko opened 6 years ago

cgrushko commented 6 years ago

Currently the resulting BUILD files are not buildable, unless you pass --nocheck_visibility.

petroseskinder commented 6 years ago

@cgrushko Style guide states that the default should not be "public" What are you thinking for the default visibility?

cgrushko commented 6 years ago

A single package group defined at the root that everyone else references, and includes the entire project.

On Sep 27, 2017 21:52, "Petros Eskinder" notifications@github.com wrote:

@cgrushko https://github.com/cgrushko Style guide states that the default should not be "public" What are you thinking for the default visibility?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/issues/11#issuecomment-332636378, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5_YXZn2gLKGKhU_2VumIlXqqPttABQks5smqeUgaJpZM4PhKMJ .