bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Use protobuf instead of dot to communicate between parsers and core #13

Closed cgrushko closed 6 years ago

cgrushko commented 6 years ago

that is, between the language-specific parsers and the language-agnostic core.

cgrushko commented 6 years ago

retest this please

petroseskinder commented 6 years ago

test this please

cgrushko commented 6 years ago

Re commit message - I think it would be better to only use the initial commit message (e.g., without 'Revert "Remove out"...'). Unless things have considerably changed in the review, the commit message that's part of the PR should usually do.

petroseskinder commented 6 years ago

Unless things have considerably changed in the review, the commit message that's part of the PR should usually do.

SGTM