search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Return class→file and file→kind from Parser #15

Closed cgrushko closed 6 years ago

cgrushko commented 6 years ago

and change the BFG ↔ Parser protocol.

Class → file is useful for languages that don't have a 1:1 relation between class names and the location they're defined at (e.g., Scala, Kotlin).

file → kind is necessary to make BFG language-agnostic enough to support JVM languages other than Java.

cgrushko commented 6 years ago

retest this please

cgrushko commented 6 years ago

@greggdonovan do you have more comments or are we good to go?

greggdonovan commented 6 years ago

LGTM

Should we move JavaSourceFileParser and ReferencedClassesParser into a ./lang/java directory in a separate commit? I can start putting PRs for Scala support into lang/scala.

cgrushko commented 6 years ago

Yeah, I prefer doing this in a separate PR.