search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Fix comment: the code expects a comma. #17

Closed greggdonovan closed 6 years ago

greggdonovan commented 6 years ago

The code expects a comma between classname and //target, not a space.

bazel-io commented 6 years ago

Can one of the admins verify this patch?

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

cgrushko commented 6 years ago

Re CLA: According to https://github.com/bazelbuild/BUILD_file_generator/commit/4d5f788b80e05020e39322da903bea6622548d47.patch the author is gdonovan@etsy.com.

greggdonovan commented 6 years ago

Thanks @cgrushko. I will update the PR with the right email. Sorry about that!

googlebot commented 6 years ago

CLAs look good, thanks!

googlebot commented 6 years ago

CLAs look good, thanks!