search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Drop SourceFileResolver and use data from source code parsers. #18

Closed cgrushko closed 6 years ago

cgrushko commented 6 years ago

Also make a slight adjustment to the BFG <-> Parser protocol: fileToRuleKind is a map, not a multimap.

cgrushko commented 6 years ago

@greggdonovan can't assign you to review this, so in case you want to...

cgrushko commented 6 years ago

Unfortunately not yet...

petroseskinder commented 6 years ago

Wait, Carmi. We never ran the ci tests, i.e. "test please". Can you hold off on merging until those give us the green light?

cgrushko commented 6 years ago

According to https://ci.bazel.io/blue/rest/organizations/jenkins/pipelines/PR/pipelines/BUILD_file_generator/runs/18/nodes/19/log/?start=0 from https://ci.bazel.io/blue/organizations/jenkins/PR%2FBUILD_file_generator/detail/BUILD_file_generator/18/pipeline/19 (linked on this page in "View details" on the merge message) I think the tests did run? Do you get test failures locally?

petroseskinder commented 6 years ago

I think the tests did run?

You're right. The logs are the source of truth. I was basing my claim on how we never explicitly asked jenkins to "test please."

cgrushko commented 6 years ago

I guess it's because you're a Collaborator with Write access, so no need for 'test please'.

On Thu, Oct 12, 2017 at 2:21 AM, Petros Eskinder notifications@github.com wrote:

I think the tests did run?

You're right. The logs are the source of truth. I was basing my claim on how we never explicitly asked jenkins to "test please."

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/18#issuecomment-335984900, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5_YRsG6PXFno_U-QGAR0j2igNvdHEeks5srVt6gaJpZM4P2LyN .