search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Move Java parser into a new lang/ directory #20

Closed cgrushko closed 6 years ago

cgrushko commented 6 years ago

for language-specific parsers.

petroseskinder commented 6 years ago

test please

cgrushko commented 6 years ago

I have a prototype Go resolver for Java, so perhaps this extra level will come handy eventually.

On Oct 12, 2017 10:05, "Petros Eskinder" notifications@github.com wrote:

@petroseskinder approved this pull request.

LGTM.

It does seem a little redundant to move it to BUILD_file_generator/lang/ java/src/test/java/com/google/devtools/build/bfg if you are going to rather than BUILD_file_generator/lang/java/src/test/com/google/ devtools/build/bfg.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/20#pullrequestreview-68935439, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5_YfSNzkyH6nYznlAoiOERBAF5OALwks5srhySgaJpZM4P2WFs .

petroseskinder commented 6 years ago

I have a prototype Go resolver for Java, so perhaps this extra level will come handy eventually.

Yay! Lets "Go"!

cgrushko commented 6 years ago

retest this please

cgrushko commented 6 years ago

Also... I kinda prefer merging my own PRs. Maybe because that's how it's done in Google :)

greggdonovan commented 6 years ago

LGTM

We should add usage documentation for the JavaSourceFileParserCli and the BFG. I'll make an issue.