(#25) Update rules_scala to a version that supports Bazel 0.7.x.

[greggdonovan]

Fix for #25

[cgrushko]

Awesome, thanks!! :D

On Mon, Oct 30, 2017 at 12:30 PM Petros Eskinder notifications@github.com wrote:

@petroseskinder approved this pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/26#pullrequestreview-72899820, or mute the thread https://github.com/notifications/unsubscribe-auth/AB5_YeCPJyRrlCxTZz9kyzxAJAx477rQks5sxfm3gaJpZM4QLeMp .

[petroseskinder]

@greggdonovan according to the CI, the change fails to build.

[greggdonovan]

Still failing in CI. Checking into it...

[greggdonovan]

Also seeing errors generating with bazel-deps:

gdonovan@3983:~/development/BUILD_file_generator (fix_rules_scala_with_bazel_0_7_0 *)$ ./dev-scripts/dependencies/generate.sh 
From https://github.com/johnynek/bazel-deps
 * branch            master     -> FETCH_HEAD
HEAD is now at b1c3502 add `--buildifier` option to `generate` to format BUILD files (fixes #73) (#90)
ERROR: /Users/gdonovan/development/bazel-deps/3rdparty/jvm/org/scala_lang/BUILD:14:1: in scala_library rule //3rdparty/jvm/org/scala_lang:scala_library: 
Traceback (most recent call last):
        File "/Users/gdonovan/development/bazel-deps/3rdparty/jvm/org/scala_lang/BUILD", line 14
                scala_library(name = 'scala_library')
        File "/private/var/tmp/_bazel_gdonovan/6fcac0fd900f6c0d2558c506b5c338d2/external/io_bazel_rules_scala/scala/scala.bzl", line 662, in _scala_library_impl
                _lib(ctx, True)
        File "/private/var/tmp/_bazel_gdonovan/6fcac0fd900f6c0d2558c506b5c338d2/external/io_bazel_rules_scala/scala/scala.bzl", line 633, in _lib
                create_java_provider(ctx, scalaattr, jars.transitive_comp...)
        File "/private/var/tmp/_bazel_gdonovan/6fcac0fd900f6c0d2558c506b5c338d2/external/io_bazel_rules_scala/scala/scala.bzl", line 566, in create_java_provider
                java_common.create_provider(ctx.actions, java_toolchain = ctx...., <4 more arguments>)
Output artifact 'external/scala/_ijar/scala-library/external/scala/lib/scala-library-ijar-ijar.jar' not under package directory '3rdparty/jvm/org/scala_lang' for target '//3rdparty/jvm/org/scala_lang:scala_library'.
ERROR: Analysis of target '//src/scala/com/github/johnynek/bazel_deps:parseproject_deploy.jar' failed; build aborted: Analysis of target '//3rdparty/jvm/org/scala_lang:scala_library' failed; build aborted.
INFO: Elapsed time: 0.159s

Investigating...

[greggdonovan]

There are two issues remaining to fix 0.7.0 support besides just updating rules_scala:

1. Update the version of bazel-deps to support 0.7.0. PR: https://github.com/johnynek/bazel-deps/pull/92

2. Either remove or update our scala_import and declare_maven rules with the changes to java providers. I will probably remove them for now to get the build to pass and open a separate issue to update them for 0.7.0.

[ittaiz]

Gregg, I posted a newer version of scala_import which supports 0.7.0 in a WIP PR of rules_scala On Mon, 30 Oct 2017 at 21:30 Gregg Donovan notifications@github.com wrote:

There are two issues remaining to fix 0.7.0 support besides just updating rules_scala:

1.

Update the version of bazel-deps to support 0.7.0. PR: johnynek/bazel-deps#92 https://github.com/johnynek/bazel-deps/pull/92 2.

Either remove or update our scala_import and declare_maven rules with the changes to java providers. I will probably remove them for now to get the build to pass and open a separate issue to update them for 0.7.0.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/26#issuecomment-340558135, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUIF5oK3rppzCqrY0SOnt3FacFQt6ULks5sxiPjgaJpZM4QLeMp .

[greggdonovan]

Terrific -- thanks @ittaiz !